Add support for int64 IDs #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienBreux
approved these changes
Oct 16, 2019
vvakame
reviewed
Oct 17, 2019
vvakame
approved these changes
Oct 18, 2019
|
@cfilby is this working using I still have this message using |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Add support for int64 IDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the GraphQL Spec, Input ID types should be coerced into strings if provided as an integer during input. In a local GraphQL API we started getting "int64 is not a string" errors when trying to pass an integer in as a resolver ID parameter while using the default graphql.ID type. We were able to recreate this behavior using the gqlgen starwars example project as well. This error does not happen while using graphql.IntID type for marshalling.
This PR adds an int64 case to the MarshalID method, which appears to resolve the issue in my quick smoke test.
Let me know if you want me to update the formatting for the test, since it looks like it diverges from the repo style.
Related Issues:
I have: